Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maestro CLI package #497

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

kirillzh
Copy link
Contributor

@kirillzh kirillzh commented Jul 9, 2024

Maestro is a tool to run mobile UI tests.

https://maestro.mobile.dev/

Resolves #407

@alecthomas
Copy link
Collaborator

Do these binaries run on all platforms?

@kirillzh
Copy link
Contributor Author

kirillzh commented Jul 9, 2024

Do these binaries run on all platforms?

Good callout. The docs mention that it's supposed to work on Mac OS, Linux, and Windows. I see the release provides with two binaries:

  • bin/maestro - I assume this one is for mac and linux
  • bin/maestro.bat - I guess that's the one for windows which current proposed manifest doesn't support? @lyonlai @alecthomas any guidance on how to update the manifest appropriately? I haven't seen any examples of current packages that unpack .bat binaries, and don't really have windows myself to test it out.

@alecthomas
Copy link
Collaborator

Hermit only supports Linux and Mac, so having just bin/maestro should be fine. I'm not sure if the .bat file is executable, but I'd probably explicitly specify bin/maestro as the binary.

Maestro is a tool to run mobile UI tests.

https://maestro.mobile.dev/

Resolves cashapp#407
@kirillzh kirillzh force-pushed the add-maestro-package branch from b1db1a0 to 9a10215 Compare July 11, 2024 16:42
@kirillzh
Copy link
Contributor Author

Hermit only supports Linux and Mac, so having just bin/maestro should be fine. I'm not sure if the .bat file is executable, but I'd probably explicitly specify bin/maestro as the binary.

Sound good, pushed the change 👍🏻

@alecthomas alecthomas merged commit 519bbba into cashapp:master Jul 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Maestro package
3 participants