-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update ruff manifest #501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To do so you will need to update all the sha256sums in the manifest file.
you will need to remove the existing entries and do hermit manifest add-digests {your package manifest}
Thank you @lyonlai. Actually I think the links works for older version til |
or maybe we do not need to worry about the old versions <=0.1.7, but will the change in this PR break existing repositories that are using |
Older versions need to remain, but you should be able to do exactly what @lyonlai suggested and everything "should" work barring weird issues. |
It looks like older versions should work since they have migrated them over as well. https://github.com/astral-sh/ruff/releases/tag/v0.1.7 For example. |
There is a slight difference, the older link has |
Yeah, the url change which you caught. I just meant that the binaries are still there. |
PR is ready for 2nd round of review cc @lyonlai @alecthomas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect the unknown
in the linux url is still messy and might be clean up for a bit in the future. But that's a problem for tmr
ruff
seems to have changed the download link, this PR to update the link and resume auto-update forruff
again.reference from https://github.com/astral-sh/ruff/releases
tested locally by installing 3 different version from 3 different categories as they have slightly different source url as well as their packaging approach has changed slightly.