Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add android cmdline-tools, add corretto@21 #530

Merged
merged 2 commits into from
Oct 31, 2024
Merged

feat: add android cmdline-tools, add corretto@21 #530

merged 2 commits into from
Oct 31, 2024

Conversation

stillmatic
Copy link
Collaborator

tested working with openjdk-21.0.3_9. corresponding JDK version wasn't added with corretto, added that too.

stillmatic
stillmatic commented Oct 29, 2024
View reviewed changes
android-cmdline-tools.hcl
source = "https://dl.google.com/android/repository/commandlinetools-linux-${version_}_latest.zip"
}

// # this is a hack because we do not have a minor version, and hermit expects a `.` in the version
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's probably a nicer way to do this but ...

@stillmatic stillmatic requested a review from alecthomas October 29, 2024 22:12
@stillmatic
Copy link
Collaborator Author

hmm CI fails with

 + hermit test -t android-cmdline-tools-11076708.0
fatal: app/test_cmd.go:36: env.go:548: Error: LinkageError occurred while loading main class com.android.sdklib.tool.sdkmanager.SdkManagerCli
	java.lang.UnsupportedClassVersionError: com/android/sdklib/tool/sdkmanager/SdkManagerCli has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0

the minimum JDK target is 17 and the environment only has 11. I don't see a good way in Hermit to require a particular JDK version though. (and can confirm that tests pass locally, when we explicitly use JDK 17 or 21). any idea how to make CI pass?

@alecthomas alecthomas merged commit 1131618 into master Oct 31, 2024
0 of 2 checks passed
@alecthomas alecthomas deleted the chua/android branch October 31, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stillmatic @alecthomas