Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Digests for CiVo and Myks #552

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Conversation

linusfr
Copy link
Contributor

@linusfr linusfr commented Dec 29, 2024

Sorry, missed this during my initial PR adding myks.

Also: can you tell me how I kick of the auto-versioning? The nightly run didn't fetch all the versions for some reasons.
And when I am running hermit -d manifest auto-version --update-digests civo.hcl or hermit -d manifest auto-version --update-digests myks.hcl locally they also don't update the files and the output is debug: Auto-versioning /<path-to-repo>/hermit-packages/<package-name>.hcl.

I can't find anything in the documentation to help me here. Help would be greatly appreciated :)
Thanks

@alecthomas
Copy link
Collaborator

strip = 0 is the default, so this will be a noop.

Auto-versioning won't backfill versions. You can use hermit manifest update-digests mkys.hcl to just update digests.

@linusfr
Copy link
Contributor Author

linusfr commented Dec 29, 2024

Oh well, then I must have made some other mistake the last time around. I removed the strip line.

Concerning digests: thanks for the add-digests command. That works. I added digests for myks and civo on here. Is that okay or shall I open a different PR?
Older versions aren't required, as long as future versions will be added. Good to know :)

Thanks for the swift responses and the help 👍🏼

@linusfr linusfr changed the title Fix Myks by Setting strip=0 Add Digests f Dec 29, 2024
@linusfr linusfr changed the title Add Digests f Add Digests for CiVo and Myks Dec 29, 2024
@alecthomas
Copy link
Collaborator

Fine in this PR, thanks!

@alecthomas alecthomas merged commit 28c3216 into cashapp:master Dec 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants