-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DuplicateRegistrationDetector for whole graph Containers #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfol
force-pushed
the
bradfol/duplicate-behavior
branch
from
November 9, 2024 00:57
7c4f38a
to
310f1bb
Compare
skorulis-ap
reviewed
Nov 11, 2024
skorulis-ap
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Not sure how we get the Swinject changes merged in.
bradfol
changed the title
Implement DuplicateDetection for whole graph Containers
Implement DuplicateRegistrationDetector for whole graph Containers
Nov 12, 2024
bradfol
force-pushed
the
bradfol/duplicate-behavior
branch
from
November 12, 2024 01:51
4827af7
to
74db318
Compare
Forwarded types are commonly created using `.implements()`
bradfol
force-pushed
the
bradfol/duplicate-behavior
branch
from
January 21, 2025 23:29
ffb7612
to
7ef7140
Compare
Container Behaviors receive instances of the `ServiceEntry` in its hook method, but are currently unable to access these properties.
The previously proposed Swinject changes (Swinject/Swinject#575) are now included in this PR as a commit |
skorulis-ap
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds runtime duplicate registration detection across entire Containers to allow for whole-graph safety.