Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DuplicateRegistrationDetector for whole graph Containers #213

Merged
merged 8 commits into from
Jan 22, 2025

Conversation

bradfol
Copy link
Collaborator

@bradfol bradfol commented Nov 9, 2024

Adds runtime duplicate registration detection across entire Containers to allow for whole-graph safety.

@bradfol bradfol force-pushed the bradfol/duplicate-behavior branch from 7c4f38a to 310f1bb Compare November 9, 2024 00:57
Copy link
Collaborator

@skorulis-ap skorulis-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Not sure how we get the Swinject changes merged in.

@bradfol bradfol changed the title Implement DuplicateDetection for whole graph Containers Implement DuplicateRegistrationDetector for whole graph Containers Nov 12, 2024
@bradfol bradfol force-pushed the bradfol/duplicate-behavior branch from 4827af7 to 74db318 Compare November 12, 2024 01:51
@bradfol bradfol force-pushed the bradfol/duplicate-behavior branch from ffb7612 to 7ef7140 Compare January 21, 2025 23:29
Container Behaviors receive instances of the `ServiceEntry` in its hook method, but are currently unable to access these properties.
@bradfol
Copy link
Collaborator Author

bradfol commented Jan 21, 2025

The previously proposed Swinject changes (Swinject/Swinject#575) are now included in this PR as a commit

@bradfol bradfol marked this pull request as ready for review January 21, 2025 23:36
@bradfol bradfol merged commit acb79d6 into main Jan 22, 2025
1 check passed
@bradfol bradfol deleted the bradfol/duplicate-behavior branch January 22, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants