Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AbstractRegistration placeholder bug #215

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

bradfol
Copy link
Collaborator

@bradfol bradfol commented Nov 12, 2024

Registered placeholders should match the service type and name of the AbstractRegistration, otherwise there are incorrect placeholders created.

@bradfol bradfol requested a review from skorulis-ap November 12, 2024 01:19
Copy link
Collaborator

@skorulis-ap skorulis-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spotting

Registered placeholders should match the service type and name of the AbstractRegistration, otherwise there are incorrect placeholders created.
@bradfol bradfol force-pushed the bradfol/placeholder-name branch from c307060 to 1f9497a Compare November 12, 2024 01:46
@bradfol bradfol enabled auto-merge November 12, 2024 01:48
@bradfol bradfol merged commit 66d9194 into main Nov 12, 2024
1 check passed
@bradfol bradfol deleted the bradfol/placeholder-name branch November 12, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants