Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concurrency support for abstract registrations #221

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

bradfol
Copy link
Collaborator

@bradfol bradfol commented Dec 13, 2024

No description provided.

@bradfol bradfol requested a review from skorulis-ap December 13, 2024 00:48
@bradfol bradfol force-pushed the bradfol/abstract-concurrency branch from fc751a4 to 0910483 Compare December 13, 2024 00:51
@bradfol bradfol force-pushed the bradfol/abstract-concurrency branch from 0910483 to 14ddc7d Compare December 13, 2024 00:55
let id = RegistrationKey(
typeIdentifier: ObjectIdentifier(Type.self),
name: name,
concurrency: .unknown
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we were to internalize and modify Swinject we could be forwarding the concurrency information we have on our concrete registrations through to this behavior

Copy link
Collaborator

@skorulis-ap skorulis-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the issue nicely

@bradfol bradfol merged commit eb127c6 into main Dec 13, 2024
1 check passed
@bradfol bradfol deleted the bradfol/abstract-concurrency branch December 13, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants