Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Knit directive to disable code gen of performance functions #233

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

skorulis-ap
Copy link
Collaborator

@skorulis-ap skorulis-ap commented Jan 24, 2025

The _autoInstantiate and _assemblyFlags functions are generated in order to improve assembler performance for large projects. In some assemblies these functions may be generated incorrectly due to an extension conforming to AutoInitModuleAssembly.
// @knit disable-performance-gen can be used to disable this code gen so it can be done manually or use the default implementation fallback.

@skorulis-ap skorulis-ap marked this pull request as ready for review January 24, 2025 02:19
@skorulis-ap skorulis-ap requested a review from bradfol January 24, 2025 02:19
Copy link
Collaborator

@bradfol bradfol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@skorulis-ap skorulis-ap merged commit 60e11b4 into main Jan 27, 2025
1 check passed
@skorulis-ap skorulis-ap deleted the skorulis/disable-performance branch January 27, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants