Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax issue in release.yml #95

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix syntax issue in release.yml #95

merged 1 commit into from
Nov 14, 2023

Conversation

skorulis-ap
Copy link
Collaborator

@skorulis-ap skorulis-ap commented Nov 9, 2023

Issues I hit on other branches. I'm not sure how to validate that the release workflow is still correct.

https://github.com/squareup/knit/actions/runs/6809724774/workflow
https://github.com/squareup/knit/actions/runs/6809878044

@skorulis-ap skorulis-ap force-pushed the skorulis/release-yaml branch from 67b49ce to 2926573 Compare November 9, 2023 09:35
@skorulis-ap skorulis-ap marked this pull request as ready for review November 9, 2023 18:17
@skorulis-ap skorulis-ap requested a review from bradfol November 9, 2023 18:18
@skorulis-ap skorulis-ap force-pushed the skorulis/release-yaml branch from 2926573 to 63601e7 Compare November 13, 2023 03:15
Copy link
Collaborator

@bradfol bradfol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks yeah I was seeing this too

@bradfol bradfol merged commit b685ffb into main Nov 14, 2023
1 check passed
@bradfol bradfol deleted the skorulis/release-yaml branch November 14, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants