Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky grpc tests #1952

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Disable flaky grpc tests #1952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions misk/src/test/kotlin/misk/client/GrpcClientProviderTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import misk.web.jetty.JettyService
import okhttp3.Response
import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.BeforeEach
import org.junit.jupiter.api.Disabled
import org.junit.jupiter.api.Test

@MiskTest(startService = true)
Expand All @@ -51,6 +52,7 @@ internal class GrpcClientProviderTest {
robotLocator = clientInjector.getInstance()
}

@Disabled("gRPC tests are flaky, see https://github.com/cashapp/misk/issues/1853")
@Test
fun happyPath() {
assertThat(log).containsExactlyInAnyOrder(
Expand Down
2 changes: 2 additions & 0 deletions misk/src/test/kotlin/misk/grpc/GrpcConnectivityTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import okhttp3.RequestBody
import okio.BufferedSink
import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.BeforeEach
import org.junit.jupiter.api.Disabled
import org.junit.jupiter.api.Test
import org.junit.jupiter.api.assertThrows
import java.io.InterruptedIOException
Expand Down Expand Up @@ -56,6 +57,7 @@ class GrpcConnectivityTest {
client = clientInjector.getInstance(OkHttpClient::class.java)
}

@Disabled("gRPC tests are flaky, see https://github.com/cashapp/misk/issues/1853")
@Test
fun happyPath() {
val request = Request.Builder()
Expand Down
2 changes: 2 additions & 0 deletions misk/src/test/kotlin/misk/web/JsonForProtoEndpointsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,14 @@ import okhttp3.RequestBody.Companion.toRequestBody
import okio.ByteString
import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.BeforeEach
import org.junit.jupiter.api.Disabled
import org.junit.jupiter.api.Test
import javax.inject.Inject

/**
* Test that we can send JSON to proto and gRPC endpoints.
*/
@Disabled("gRPC tests are flaky, see https://github.com/cashapp/misk/issues/1853")
@MiskTest(startService = true)
internal class JsonForProtoEndpointsTest {
@MiskTestModule
Expand Down