reduce checksum failures #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgo
force-pushed
the
mtocker-test-checksum-failure
branch
2 times, most recently
from
215a93a
to
5fbc94e
Compare
morgo
force-pushed
the
mtocker-test-checksum-failure
branch
from
5fbc94e
to
81bc1db
Compare
prudhvi
reviewed
Mar 8, 2024
| // With the lock held, flush one more time under the lock tables. | ||
| // Because we know canal is up to date this now guarantees | ||
| // we have everything in the new table. | ||
| if err := c.feed.Flush(ctx); err != nil { | ||
| if err := c.feed.FlushUnderLock(ctx, serverLock); err != nil { |
There was a problem hiding this comment.
IIUC, This is also a important change to reduce the chances the below check AllChangesFlushed() failing due to parallelism, but I guess not the reason the migrations under consideration failed, as they failed in the checksum phase.
prudhvi
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Pull Request should be associated with an Issue.
This is another attempt to fix #248
There seems to be a case where the checksum is failing, and inspection of the rows show that it's not garbled data but a
last_viewed_at DATETIME(3)column which an update was missed for.All the cases affected appear to be resume cases (typically it's gone to resume because it has high lock wait timeouts while trying to get a lock). Which leads me to believe it's:
Note: (2) is more likely since (1) occurs under both resume and non-resume cases. I don't think the cause is (3).
There is also a little bit more cleanup to remove 5.7 support.