Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added note to usage regarding instant DDL and defer-cutover #276

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Added note to usage regarding instant DDL and defer-cutover #276

merged 1 commit into from
Mar 19, 2024

Conversation

kolbe
Copy link
Collaborator

@kolbe kolbe commented Mar 19, 2024 •
edited by morgo
Loading

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.
Further notes in https://github.com/cashapp/spirit/blob/main/.github/CONTRIBUTING.md

Documents behavior raised in #275 / Fixes #275

@kolbe kolbe requested a review from morgo March 19, 2024 19:57
morgo
morgo approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo morgo merged commit a832aa1 into main Mar 19, 2024
9 checks passed
@morgo morgo deleted the kolbek-docs branch March 19, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

defer-cutover flag issue on mysql 8.0.32
2 participants
@kolbe @morgo