Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support invisible indexes better #284

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Support invisible indexes better #284

merged 4 commits into from
Apr 18, 2024

Conversation

morgo
Copy link
Collaborator

@morgo morgo commented Apr 18, 2024

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.
Further notes in https://github.com/cashapp/spirit/blob/main/.github/CONTRIBUTING.md

Fixes #283

@morgo morgo requested a review from kolbe April 18, 2024 16:12
kolbe
kolbe approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@kolbe kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo morgo merged commit 886ee21 into main Apr 18, 2024
9 checks passed
@morgo morgo deleted the mtocker-invisible-indexes branch April 18, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolbe kolbe kolbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ALTER INDEX x [VISIBLE|INVISIBLE] counts as inplace
2 participants
@morgo @kolbe