Skip to content

Commit

Permalink
ExtendedNLogFactory - Removed explicit loading of nlog.config by defa…
Browse files Browse the repository at this point in the history
…ult, since NLog will automatically load its configuration
  • Loading branch information
snakefoot committed Nov 12, 2018
1 parent 8f3fb9e commit f18057d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Deprecations:

Enhancements:
- Recognize read-only parameters by the `In` modreq (@zvirja, #406)
- NLogFactory will no longer load NLog.config by default, since NLog does it automatically (@snakefoot, #419)
- NLogFactory and ExtendedNLogFactory will no longer load NLog.config by default, since NLog does it automatically (@snakefoot, #419)

## 4.3.1 (2018-06-21)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,14 @@ public class ExtendedNLogFactory : AbstractExtendedLoggerFactory
{
/// <summary>
/// Initializes a new instance of the <see cref="ExtendedNLogFactory" /> class.
/// Configures NLog with a config file name 'nlog.config'
/// <seealso cref="Create(string)" />
/// </summary>
public ExtendedNLogFactory()
: this(NLogFactory.defaultConfigFileName)
: this(true)
{
}

/// <summary>
/// Initializes a new instance of the <see cref="ExtendedNLogFactory" /> class with the configfile specified by <paramref
/// name="configFile" />
/// Initializes a new instance of the <see cref="ExtendedNLogFactory" /> class.
/// </summary>
/// <param name="configFile"> The config file. </param>
public ExtendedNLogFactory(string configFile)
Expand All @@ -50,7 +47,7 @@ public ExtendedNLogFactory(string configFile)
/// <summary>
/// Initializes a new instance of the <see cref="ExtendedNLogFactory" /> class.
/// </summary>
/// <param name="configuredExternally"> If <c>true</c> . Skips the initialization of log4net assuming it will happen externally. Useful if you're using another framework that wants to take over configuration of NLog. </param>
/// <param name="configuredExternally">If <c>true</c>. Skips the initialization of NLog assuming it will happen externally (or automatically by NLog).</param>
public ExtendedNLogFactory(bool configuredExternally)
{
if (configuredExternally)
Expand Down

0 comments on commit f18057d

Please sign in to comment.