Moved Castle.Core compatibility layer down to Castle.Windsor #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonorossi
requested changes
Feb 21, 2017
| { | ||
| using System.Collections.Generic; | ||
|
|
||
| // This allows us to use the new reflection API while still supporting .NET 3.5 and 4.0. |
There was a problem hiding this comment.
I think it is about time we discussed the plans for Windsor v4, we are dropping all Silverlight and I think we should drop .NET Framework 3.5 and 4.0 including any client profile ugliness... see #185.
That being that case, much of this isn't needed because .NET 4.5 added GetTypeInfo and some friends. You can even see that the .NET 4.5 build of Castle Core doesn't define FEATURE_LEGACY_REFLECTION_API (https://github.com/castleproject/Core#conditional-compilation-symbols).
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved all compatibility classes from Castle.Core down to Windsor for anticipation of migration to dotnet core.