editing the expriments-msmarco-passage file and putting the relevant windows code #2583
Conversation
merging my changes of expriments-msmarco-passage file to master
docs/experiments-msmarco-passage.md
Outdated
| @@ -101,6 +102,15 @@ bin/run.sh io.anserini.index.IndexCollection \ | |||
| -generator DefaultLuceneDocumentGenerator \ | |||
| -threads 9 -storePositions -storeDocvectors -storeRaw | |||
| ``` | |||
| In Windows: | |||
| ```bash | |||
| java -cp target\anserini-0.12.0-fatjar.jar io.anserini.index.IndexCollection ^ | |||
There was a problem hiding this comment.
This doesn't look right... anserini is up to release v0.37.0 now.
If you want to go this route, add a bin/run.bat or equivalent run script for Windows?
There was a problem hiding this comment.
yes, sorry for my mistake. Actually, I use anserini v0.37.1 for the windows scripts.
There was a problem hiding this comment.
I would still like a "launch script" that parallels bin/run.sh so that we don't need to change the version of the fatjar every time we do a release.
There was a problem hiding this comment.
I will write code for it and again make a new pull request for that.
|
I also edit the java version which i used. I am using version 22. |
docs/experiments-msmarco-passage.md
Outdated
| + Results reproduced by [@npjd](https://github.com/npjd) on 2024-08-17 (commit [`46b6834`](https://github.com/castorini/anserini/commit/46b68345b0ee614f511b87c9f66cee399e1308c5)) | ||
| + Results reproduced by [@setarehbabajani](https://github.com/setarehbabajani) on 2024-08-30 (commit [`ff0a69ac`](https://github.com/castorini/anserini/commit/ff0a69acf93fd7e05e65fb3dd6fa2cda41f583ff)) |
There was a problem hiding this comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Please fix this?
There was a problem hiding this comment.
i put the code of win-run.bat and also change the bash code inside the document.
For commit, sorry I do not understand what is the problem. I change the code in the forked repository and then create pull request to the main anserini repository.
There was a problem hiding this comment.
When I go to your URL, it refers to a commit that's not part of the repo. It should refer to an actual commit point in Anserini. Your other URL is fine.
There was a problem hiding this comment.
sorry for the confusion. I put the commit id of the commit of my forked repository. Is not correct? Because the pull request is not merged, I can just access to my local commit id.
There was a problem hiding this comment.
no, don't point to the fork. point to a commit id in anserini master.
There was a problem hiding this comment.
thanks a lot. I think everything is now okay.
windows-bat/win-run.bat
Outdated
| @@ -0,0 +1,20 @@ | |||
| @echo off | |||
There was a problem hiding this comment.
why not rename bin/run.bat to be consistent?
Not sure we need a new directory...
There was a problem hiding this comment.
I agree but the bin directory is ignored due to .gitignore file. Because of that, I make new directory and put code there.
I end up doing "Anserini: Start Here" and "BM25 Baselines for MS MARCO Passage Ranking in Anserini" parts on Windows 10 using commit. I used Python 3.12.5 and Maven 3.9.9, java version 22. I used Windows 10 and 64-bits operating system. For the first part, I faced minor issues with the Maven setup, which were resolved by correcting environment variables and for the second part, the retrieval of the documents took too long time from me. But finally, all steps worked as expected. I eagerly follow the next steps of onboarding .