-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added reproduction log entry for BM25 MS MARCO Passage Ranking #2600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major refactoring of indexing pipeline (IndexCollection, IndexHnswDenseVectors, and IndexInvertedDenseVectors), extracting common code paths into AbstractIndexer.
+ Refactored to create HnswDenseSearcher and InvertedDenseSearcher; these will provide Python bindings (later) + Refactored SearchHnswDenseVectors and SearchInvertedDenseVectors as wrappers to provide main + Improved test coverage
* add PrebuiltIndexHandler * add a download progress bar * add MD5 checksum checking * add gzip and unzip tarball functionalities * add corresponding unittests
Also added HNSW int8 regressions: works for cosDPR-distill, issues remain with OpenAI Ada2
+ Improved alignment between SearchCollection and dense vector search classes. + Aligned ScoredDoc and ScoredDocs (was previously ScoredDocuments) as container objects for Lucene results. + Searchers now use ScoredDoc instead of class-specific Result objects. + Tweaked SearchCollection args to use proper camelCasing. + Consolidated BaseSearcher class for basic ranked list post-processing functionality. + Increased test coverage.
…ings (#2318) Default of 2047 seems to be too aggressive for hops, getting OOM errors.
…and Sparse Representations Using Lucene" (#2317)
+ simplified parameters in cases where there are default (for BEIR) + moved "threads" parameter up closer to beginning of command (for indexing, all regressions)
+ dense searchers batch_search - change method signature to take queries, then qids - to be consistent with SimpleSearcher and SimpleImpactSearcher + dense searchers: refactor ThreadPoolExecutor to use try-with-resources, see #2579
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Please continue along the onboarding path until you reach the end of the exercises, and then we'll take a look all at once. |
RMaarefdoust
force-pushed
the
master
branch
from
September 16, 2024 18:15
3327c59
to
9f7b76b
Compare
|
I did it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes an update to the reproduction log for the BM25 MS MARCO Passage Ranking. The entry has been added to document the reproduction results for this specific baseline.
Details:
System Environment: