Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add batteries and solar panels to LMOE shelter #4460

Merged
merged 7 commits into from
Apr 10, 2024

Conversation

arijust
Copy link
Contributor

@arijust arijust commented Apr 10, 2024

Purpose of change

Add renewable electricity to lmoe shelter.

Describe the solution

Change broken generator into storage battery.
Add solar panel on roof.

Describe alternatives you've considered

Nothing.

Testing

Should load in changed mapgen. Not sure about already existing ones.

Additional context

Should consider adding long cable, if there isn't one in-game already.

arijust added 2 commits April 10, 2024 02:15
Change broken generator to storage battery.
Add solar panel to palette.
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Apr 10, 2024
chaosvolt
chaosvolt previously approved these changes Apr 10, 2024
@chaosvolt chaosvolt dismissed their stale review April 10, 2024 01:01

oh wait terrain missing

@scarf005 scarf005 changed the title Lmoe shelter update feat: add generator to LMOE shelter Apr 10, 2024
Moved solar panel into bunker_ext palette
Upgraded solar panel into v2.
@Lamandus Lamandus changed the title feat: add generator to LMOE shelter feat: add batteries and solar panels to LMOE shelter Apr 10, 2024
@scarf005 scarf005 self-requested a review April 10, 2024 10:06
@scarf005 scarf005 self-assigned this Apr 10, 2024
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image

might make sense to change those slopes into ramps later to it could be climbed without < or >

@scarf005 scarf005 merged commit 5960913 into cataclysmbnteam:main Apr 10, 2024
10 checks passed
@arijust arijust deleted the Lmoe_shelter_update branch April 19, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants