chore(UI): Unbind suicide, provide defaults for others such as Spellcasting #4503
Conversation
|
I mean, who uses the suicide keybind anyway? Like, genuinely. It seems pretty niche, and we've got a load of other niche keybinds that are unbound by default |
|
Hey, Lamandus here. Some thing to consider:
While you did your own spin on it, unbinding suicide is also something DDA did beforehand. Maybe Linking their PR to attribute, wouldn't be a bad idea, if I remember it all correctly. |
i think it's not right to attribute PRs not actually done by them |
The question is, if the result is the same, (unbinding), can we prove it? I just don't want any trouble |
if removing a keybind can cause trouble i'm afraid there's nothing else we can edit without trouble |
If you say so. Okey. Still I would consider the |
|
The Quit keybind is likely a holdover from the older Roguelikes Cata is based on, and from a time when Cata was much shorter and more closely reminiscent of a Roguelike experience. It probably doesn't fit anymore cause we rarely have truly run-ending situations and the games usually run a bit longer than the standard Roguelike. It's probably fine to remove it, but I'd appreciate not disparaging it without thought. |
Holy hecc Auto Travel is smooth and looks great. I suppose I'll just put that on... comma for now, since that's convenient and not currently bound to anything by default |
Thanks Viss, very cool suggestion
|
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
|
Huh, the auto-linter in VSCode didn't catch that smol error somehow. Oh well, the keybinds file is a lil unusual. |
You need to enable |
|
Ah, good point. Thanks ^-^ |
Yeah, if the PR OP did the change as their own work with no influence from DDA, especially for something that's a no-brainer like this, then that's their problem if they call us out for "stealing" something that's basically convergent evolution. |
|
Indeed. DDA can't own the concept of unbinding the suicide key by default lmao |
|
I must be the only player who smashes Shift Q like a maniac after I'm done testing something :x |
Probably. I use debug quit usually |
Considering I didn't even realize we had a LUA console, I'd think that's more of a developer concern than a player one. Plus, then we have to decide where we're putting the debug menu. |
how about |
|
I'll gladly put the LUA Console on F11 |
oh, i meant debug menu on |
|
Ah, okay. |
|
Wait, can't you already access the LUA console from the debug menu anyway? That kinda makes debug menu vastly more useful as a binding for this anyway... |
It totally is! |
|
Yeah I predict everyone who actually cares about debugging, even LUA modders, are gonna end up changing this binding anyway since they're gonna need the regular debug functions to test stuff as well... |
|
to be fair, almost every games have |
|
The thing already had not one but two case sensitive prompts |
sorry, this PR has been closed a while ago, could you be explicit on which keybind changes? |
|
They most likely mean the quit command, as that indeed has multiple prompts before it kicks in. I noted that I was a bit leery of approving it, but now I've noticed an actual genuine issue with this: we don't have a bind for this in the escape menu, and debug "quit without saving" is NOT an adequate substitute for this. If you have a world with more than one character in it and want to get rid of one (for example, one was a test character you had to save/load with and the other is your actual playthrough, because you forgot to create a separate world for testing), you have no option to actually clear that character unless you re-bind the suicide key, unless you want to reset the world and fuck over your actual playthrough save too. Only other things would be more obscure debug methods like setting your HP to zero or otherwise actually getting yourself killed in-game, which is not what we want to encourage players to go do just so they can clear out an unneeded character in a save they're still using. |
|
It's just a single keybind that the small fraction who would need to delete such characters on any regular basis would need to re-bind. Additionally, having the Suicide key be bound by default for that reason seems like... a bit of a bandaid hiding the real issue of the fact that's not an option in some place like the main menu? |
|
Seems like I probably should tinker with a PR to add a bind for it to the escape menu at some point... |
|
Yeah I had to dick around in the kebind menu for a bit to find the actual keybind in the first place, quit didn't show up anything so I thought it had been a DDA situation where they straight up removed the thing, until I explicitly checked the PR and actually tried looking for for "suicide" instead of quit, which was more than a tad unintuitive given the situation |
Purpose of change
Why we even had suicide bound by default, and to 'Q' of all keys, is a mystery to me. A mystery that can now be rectified.
Also, we were missing defaults for spellcasting, debug menu, and opening the diary, so I provided some for those upon receiving feedback.
Describe the solution
]by default (it's right next to the mutations default on the keyboard)`by default (also known as the grave key, or the default in a wide variety of other games)Homekey on the keyboard by defaultDescribe alternatives you've considered
Continuing to have to advise players against pressing 'Q', then Yes twice
Leaving Spellcasting unbound by default
Testing
It doesn't crash when I load in, and it looks like this should work.
Additional context
"Watch how with just one simple trick, we reduced the number of player-suicides in Cata by 99.99%!"