Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix sauce sandwich containing dairy and meat #4507

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

RobbieNeko
Copy link
Collaborator

Purpose of change

Fixes the fact that sauce sandwiches made out of entirely okay ingredients would suddenly trigger lactose intolerance (and presumably meat intolerance / allergy too) for no reason.

Describe the solution

Explicitly defines materials to prevent it inheriting the deluxe sandwhich's materials

Describe alternatives you've considered

  • Leave the dairy matter because technically butter is a valid ingredient, and brioche and biscuits are made with milk
    • The vast majority of the ingredients are non-dairy. As such, ingredient democracy has dairy removal winning.

Testing

image

Additional context

Are there other oddities in the sandwiches file? Maybe, but it'd be good PR fodder for new contributors if they notice something. I just thought this one was particularly egregious, and I saw it being talked about firsthand.

technically it can have butter as an ingredient, but every other sauce is non-dairy. Democracy of ingredients.
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Apr 21, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:>

@VissValdyr
Copy link
Contributor

VissValdyr commented Apr 21, 2024

Interesting error. I made the sandwich revamp not long ago #4456 . Changing the files and recipes generously. I hope there aren't that much other errors for that many new contributiors. 😅

@chaosvolt chaosvolt merged commit d8f3823 into cataclysmbnteam:main Apr 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants