Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(port): Rabbit Mutations #5885

Merged
merged 12 commits into from
Feb 2, 2025

Conversation

Zlorthishen
Copy link
Contributor

@Zlorthishen Zlorthishen commented Jan 6, 2025

Checklist

Required

Optional

Purpose of change

ports the following dda pull requests

Describe the solution

Describe alternatives you've considered

Testing

image

Additional context

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 6, 2025
Copy link
Contributor

autofix-ci bot commented Jan 6, 2025

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@Zlorthishen Zlorthishen marked this pull request as ready for review January 26, 2025 02:04
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

looks like tests fail due to mutation breach chance being too low

@chaosvolt
Copy link
Member

Looks like it's specifically beast category being failed here:

 -------------------------------------------------------------------------------
Having all pre-threshold mutations gives a sensible threshold breach chance
      Given: The player has all pre-threshold mutations for BEAST
       Then: Threshold breach chance is at least 0.2
-------------------------------------------------------------------------------
D:\a\Cataclysm-BN\Cataclysm-BN\tests\mutation_test.cpp(123)
...............................................................................

D:\a\Cataclysm-BN\Cataclysm-BN\tests\mutation_test.cpp(125): FAILED:
  CHECK( breach_chance >= BREACH_CHANCE_MIN )
with expansion:
  0.1949f >= 0.2f
with message:
  MUTATIONS: DEFT SHOUT2 CARNIVORE TERRIFYING SMELLY2 MYOPIC PADDED_FEET
  FEL_EYE ADRENALINE HEAVYSLEEPER2 SLEEPY ANTIJUNK NIGHTVISION ANIMALDISCORD
  FELINE_FUR CLAWS PHEROMONE_MAMMAL TAIL_FLUFFY CANINE_EARS DEFORMED2 MUZZLE
  HUNGER2 TROGLO PAWS_LARGE SNARL 

So it's presumably not that Rabbit thresh is too hard to cross, but some mutations given to Rabbit are also important to Beast category.

Zlorthishen and others added 2 commits January 30, 2025 20:32
@Zlorthishen
Copy link
Contributor Author

Zlorthishen commented Feb 2, 2025

Female
image
Male
image

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untitled

@chaosvolt chaosvolt merged commit 243a679 into cataclysmbnteam:main Feb 2, 2025
13 checks passed
@Zlorthishen Zlorthishen deleted the Rabbit-mutations branch February 2, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants