Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): House solar odds lowered from 33% per home to 15% #5896

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

RoyalFox2140
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 commented Jan 7, 2025

Checklist

Required

Purpose of change

Solar roofs go from 8, to 9, to 16 panels on residential homes. They're also very common. I think dialing it back should be okay, houses are something you spend all game securing and looting.

Describe the solution

The odds were at a distribution with 30 odds of nothing, and 5 odds for 8, 9, and 16 panels respectively. This is 11% chance per solar odd, and a total of 33% for any solar. I think this is too high.

I've set a 15% chance for solar panels, at 2% odds for 16 panels, 8% for 8 panels, and 5% for 9 panels. This is still a significantly large amount as 8 panels is amazing to find. at 15% chance per house you're generally going to find one house in a neighborhood of 10 homes that has these panels. Whereas before every third house would have solar statistically (For each home which calls this nested mapgen specifically)

Describe alternatives you've considered

A lot of other stuff. Let's just take a small and easy approach.

Testing

They still do spawn.
image

Additional context

That's it until we get more data, and until I can steal Chaos for power balancing.

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 7, 2025
@RoyalFox2140 RoyalFox2140 requested a review from chaosvolt January 7, 2025 18:51
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough. Reducing the total number of panels to something like 2x2, 2x3, and 2x4 could be an acceptable alternative too.

@chaosvolt chaosvolt merged commit 5247f85 into cataclysmbnteam:main Jan 7, 2025
13 checks passed
@RoyalFox2140 RoyalFox2140 deleted the solarroofs branch January 7, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants