Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): Permit One-handed casting #5919

Merged
merged 4 commits into from
Jan 11, 2025

Conversation

RobbieNeko
Copy link
Collaborator

Checklist

Required

Purpose of change

Spellcasting with one hand is cool, and this seems like a generally desired change for the sake of giving the non-two handed weapons a bit more of a place.

Describe the solution

  • Allows casting with one-handed weapons, but unless they're arcane focuses or the spell is marked as not requiring hands then they 1.5x the casting cost of the spell.

Describe alternatives you've considered

  • Base the penalty off the weight of the weapon you're holding

That looked difficult, and also the simple fact that you have a hand impeded in general is reason enough for a decently considerable casting time nerf.

Testing

It builds, and I confirmed expected behavior:

  • Casting Magic Missile unimpeded costs 100 moves
  • Casting it with a combat knife in my hand costs 150
  • Casting with a zweihander is still impossible
  • An animist's athame doesn't receive the penalty
  • A lesser Magi's staff can still be used for casting, and also doesn't induce a penalty
  • Windstrike correctly doesn't get its moves multiplied since it doesn't need hands

Additional context

Spellswords/battle mages rejoice!

Allow one-handed weapons to impede, but not stop, casting.
@github-actions github-actions bot added the src changes related to source code. label Jan 11, 2025
Copy link
Contributor

autofix-ci bot commented Jan 11, 2025

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

RoyalFox2140
RoyalFox2140 previously approved these changes Jan 11, 2025
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the formatting should appease scarf now

@chaosvolt chaosvolt merged commit 3bcc1a4 into cataclysmbnteam:main Jan 11, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants