Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mods/Magical_Nights): Add an acknowledgement for sources of certain tiles #5927

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

RobbieNeko
Copy link
Collaborator

Checklist

Required

Purpose of change

As it turns out, the tileset we had for Magiclysm (and that Magical Nights thusly inherited) used a bunch of recolors of Dungeon Crawl: Stone Soup and RLTiles item sprites for the wands (if not more). While the wand sprites recolored are under CC0 and public domain for both sources respectively, it still feels best to acknowledge them.

Describe the solution

Adds an acknowledgement of where the tiles came from, as RLTiles politely requests and as DCSS likely appreciates.

Describe alternatives you've considered

  • Also include a notice asking people to please reach out first if they think they see any violations
  • Do nothing, CC0 (and public domain) don't legally require attribution in the first place

Testing

I read it and it is indeed intelligible English.

Additional context

I swear, if there's a tile in the tileset that MN inherited that turns out to be copyright infringement, I'm gonna weh so hard I'll give Chaos a run for his money.

Hopefully all parties should be reasonable if such an event ever does happen though

@github-actions github-actions bot added JSON related to game datas in JSON format. mods PR changes related to mods. labels Jan 13, 2025
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awawa

@RobbieNeko RobbieNeko merged commit 96c24bc into cataclysmbnteam:main Jan 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants