Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: All bandoliers that accept .38 special now accept .38 super #6000

Merged

Conversation

RoyalFox2140
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 commented Jan 28, 2025

Purpose of change (The Why)

Bandoliers are set up in a bad way code-wise where you manually define all valid ammo types. A ton are set to accept .38 and .357 magnum but not .38 super

Describe the solution (The How)

Checked all bandoliers in the game to ensure if it accepted .38 special it can now accept .38 super.

Describe alternatives you've considered

We need a min_volume and max_volume support on bandoliers but for bullets instead of knife sheathing.

Testing

It loads in my world.
image

Additional context

:(

Checklist

Mandatory

Sorry, something went wrong.

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 28, 2025
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:>

@chaosvolt chaosvolt merged commit 50d2b57 into cataclysmbnteam:main Jan 28, 2025
13 checks passed
@RoyalFox2140 RoyalFox2140 deleted the nothing-will-stop-our-bullets branch January 28, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants