Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clean up item categories more #6020

Merged

Conversation

RoyalFox2140
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 commented Jan 31, 2025

Purpose of change (The Why)

It needed to be done for organization and consistency

Describe the solution (The How)

I had 3 lists from coolthulhu plus what I remembered from gameplay. I updated to the best of my ability.

Describe alternatives you've considered

Dying. Going and committing Roblox. Making Chaosvolt do the rest because this is a morale break with how many items are still left to double check.

Testing

No, that's the tests.

Additional context

I am in so much pain, let me not understate that due to how many items we have.

Checklist

Mandatory

im done for now
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 31, 2025
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pain

data/json/items/ammo.json Outdated Show resolved Hide resolved
data/json/items/melee/swords_and_blades.json Outdated Show resolved Hide resolved
data/json/items/melee/swords_and_blades.json Outdated Show resolved Hide resolved
data/json/items/melee/swords_and_blades.json Outdated Show resolved Hide resolved
data/json/items/melee/swords_and_blades.json Outdated Show resolved Hide resolved
data/json/items/tool/lighting.json Outdated Show resolved Hide resolved
data/json/items/tool/misc.json Outdated Show resolved Hide resolved
data/json/items/tool/misc.json Outdated Show resolved Hide resolved
data/json/items/tool/misc.json Outdated Show resolved Hide resolved
data/json/items/tool_armor.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the mods PR changes related to mods. label Jan 31, 2025
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awawawa

data/json/items/tool/misc.json Outdated Show resolved Hide resolved
data/json/items/tool/woodworking.json Outdated Show resolved Hide resolved
data/json/items/tool/woodworking.json Outdated Show resolved Hide resolved
data/json/items/tool_armor.json Outdated Show resolved Hide resolved
data/json/items/tool_armor.json Outdated Show resolved Hide resolved
data/json/items/tool_armor.json Outdated Show resolved Hide resolved
data/json/items/tool_armor.json Outdated Show resolved Hide resolved
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Category and BsomethingJSONrelatedIcan'tthinkofawordthatstartswithBtogohere Torture

@RoyalFox2140
Copy link
Collaborator Author

Ubuntu test failure is unrelated.

@RoyalFox2140 RoyalFox2140 merged commit f649282 into cataclysmbnteam:main Jan 31, 2025
10 of 13 checks passed
@RoyalFox2140 RoyalFox2140 deleted the life-is-misery-and-pain-whats-up branch February 1, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants