-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: clean up item categories more #6020
feat: clean up item categories more #6020
Conversation
im done for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pain
Co-authored-by: Chaosvolt <[email protected]>
Co-authored-by: Chaosvolt <[email protected]>
Co-authored-by: Chaosvolt <[email protected]>
Co-authored-by: Chaosvolt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awawawa
Co-authored-by: Chaosvolt <[email protected]>
Co-authored-by: Chaosvolt <[email protected]>
Co-authored-by: Chaosvolt <[email protected]>
Co-authored-by: Chaosvolt <[email protected]>
Co-authored-by: Chaosvolt <[email protected]>
Co-authored-by: Chaosvolt <[email protected]>
Co-authored-by: Chaosvolt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Category and BsomethingJSONrelatedIcan'tthinkofawordthatstartswithBtogohere Torture
Ubuntu test failure is unrelated. |
Purpose of change (The Why)
It needed to be done for organization and consistency
Describe the solution (The How)
I had 3 lists from coolthulhu plus what I remembered from gameplay. I updated to the best of my ability.
Describe alternatives you've considered
Dying. Going and committing Roblox. Making Chaosvolt do the rest because this is a morale break with how many items are still left to double check.
Testing
No, that's the tests.
Additional context
I am in so much pain, let me not understate that due to how many items we have.
Checklist
Mandatory
closes #1234
in Summary of the PR so it can be closed automatically.main
so it won't cause conflict when updatingmain
branch later