Use a test to identify lost facts & assert some stuff about them #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One day, we will be able to run this test in CI and it will tell us when there are too many lost facts.
For now, we're just using the test as a simple script runner that helps us explore the lost facts.
TODO:
We might want to assert something like "in every instance, the % of lost facts named
order_number
is less than 0.5% of the total facts".Or, we might want to assert something like "in every instance, the % of lost facts at all is less than 1% of the total facts."
Or, "across all instances at once, the % of lost facts is < X%"