Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a test to identify lost facts & assert some stuff about them #106

Closed
wants to merge 3 commits into from

Conversation

jdangerx
Copy link
Member

@jdangerx jdangerx commented Jul 27, 2023

One day, we will be able to run this test in CI and it will tell us when there are too many lost facts.

For now, we're just using the test as a simple script runner that helps us explore the lost facts.

TODO:

  • get more statistics out (e.g. including the context dimensions in the statistics)
  • assert across all instances

We might want to assert something like "in every instance, the % of lost facts named order_number is less than 0.5% of the total facts".

Or, we might want to assert something like "in every instance, the % of lost facts at all is less than 1% of the total facts."

Or, "across all instances at once, the % of lost facts is < X%"

@jdangerx jdangerx linked an issue Jul 27, 2023 that may be closed by this pull request
@jdangerx jdangerx requested a review from zschira July 27, 2023 21:28
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jdangerx
Copy link
Member Author

Closing in favor of catalyst-cooperative/pudl#2774

@jdangerx jdangerx closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Identify lost XBRL facts
2 participants