Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive NREL Electrification Futures Studies #564

Draft
wants to merge 5 commits into
base: marianneke-generalize-hyperlink-extractor
Choose a base branch
from

Conversation

e-belfer
Copy link
Member

@e-belfer e-belfer commented Jan 31, 2025

Overview

Closes #558

What problem does this address?

What did you change in this PR?

Questions for reviewers

  • How should I partition / bundle these files? Should I be zipping more aggressively? Do the partitions I'm using make sense?

Testing

How did you make sure this worked? How can a reviewer verify this?

Prod draft: https://zenodo.org/uploads/14782874

To-do list

Tasks

Preview Give feedback

@e-belfer e-belfer changed the title Archive NREL Electrificatio Futures Studies Archive NREL Electrification Futures Studies Jan 31, 2025
@katie-lamb
Copy link
Member

@e-belfer I checked the draft archive against the data source and it looks complete to me

elif "data.nrel.gov/submissions/" in link:
self.logger.info(f"Downloading data files from {link}.")
data_links = await self.get_hyperlinks(link, data_pattern)
for data_link, filename in data_links.items():
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zaneselvans See this

@zaneselvans zaneselvans linked an issue Feb 1, 2025 that may be closed by this pull request
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

Write an archiver for NREL's Electrificaiton Futures Studies
2 participants