Debug daily metrics GHA #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-belfer
added
kaggle
e-belfer
requested review from
bendnorman and
jdangerx
and removed request for
bendnorman
jdangerx
approved these changes
Sep 17, 2024
!! but also I have some questions about the various auth changes. Nothing blocking, just curious why they had to be done| @@ -22,7 +22,7 @@ jobs: | |||
| with: | |||
| environment-file: environment.yml | |||
| cache-environment: true | |||
| ondarc: | | |||
There was a problem hiding this comment.
-_- my eyes completely glazed over this during the first review
| workload_identity_provider: "projects/345950277072/locations/global/workloadIdentityPools/gh-actions-pool/providers/gh-actions-provider" | ||
| service_account: "pudl-usage-metrics-etl@catalyst-cooperative-pudl.iam.gserviceaccount.com" | ||
| create_credentials_file: true | ||
| credentials_json: "${{ secrets.GCP_USAGE_METRICS_ARCHIVER_KEY }}" |
There was a problem hiding this comment.
Hmm, sure, but what was the issue with WIF?
There was a problem hiding this comment.
This was done to give this archiver write access and to keep the ETL account as having read-only access to the archived files.
There was a problem hiding this comment.
Makes sense! Do you have a new service account now? Is it in Terraform / if not, do you want help putting it in Terraform?
There was a problem hiding this comment.
Let me move this question into the living terraform PR (catalyst-cooperative/pudl#3841), as @bendnorman set up the account and would know better.
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What problem does this address?
Fixes problems with the archiving action created in #162.
What did you change in this PR?
Testing
How did you make sure this worked? How can a reviewer verify this?
Run the
save-daily-metrics.ymlworkflow and verify that it works as expected.To-do list
Tasks