Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save_daily_metrics.yml import error #199

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

e-belfer
Copy link
Member

@e-belfer e-belfer commented Oct 8, 2024

Overview

Closes #198.

What problem does this address?
Fixes an import error caused by the outdated datasette and intake jobs, which was caused by moving the requests.get() call to helpers.py in #187. This was masked by the micromamba failures for several days.

What did you change in this PR?
Reverted the change in #187, as it is not essential. The more thorough solution would be to deprecate the unneeded jobs, which we should do once datasette data is being ETL'd in #128. I made the change initially in order to facilitate eventually adding some retries to the get request. However, given that this is function basically glorified error message formatting at this point, I'd prefer to leave the datasette code as-is to inform the near-term ETL, and then revisit this question later.

Testing

How did you make sure this worked? How can a reviewer verify this?
Run save_daily_metrics.yml.

To-do list

Tasks

@e-belfer e-belfer self-assigned this Oct 8, 2024
@e-belfer e-belfer added the bug Something isn't working label Oct 8, 2024
@e-belfer e-belfer requested a review from jdangerx October 8, 2024 18:15
Copy link
Member

@jdangerx jdangerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You win some, you lose some 🤷 Looks good to me!

@e-belfer e-belfer merged commit ee3a816 into main Oct 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

save-daily-metrics action failing with error about $POSTGRES_USER
2 participants