Fix save_daily_metrics.yml
import error
#199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #198.
What problem does this address?
Fixes an import error caused by the outdated
datasette
andintake
jobs, which was caused by moving therequests.get()
call tohelpers.py
in #187. This was masked by the micromamba failures for several days.What did you change in this PR?
Reverted the change in #187, as it is not essential. The more thorough solution would be to deprecate the unneeded jobs, which we should do once datasette data is being ETL'd in #128. I made the change initially in order to facilitate eventually adding some retries to the get request. However, given that this is function basically glorified error message formatting at this point, I'd prefer to leave the datasette code as-is to inform the near-term ETL, and then revisit this question later.
Testing
How did you make sure this worked? How can a reviewer verify this?
Run
save_daily_metrics.yml
.To-do list
Tasks