Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcloud set up in load-metrics.yml #200

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

e-belfer
Copy link
Member

@e-belfer e-belfer commented Oct 11, 2024

Overview

What problem does this address?
I'm not 100% sure what caused the issue, but the load_metrics.yml was suddenly having a problem authenticating gcloud (see, e.g. https://github.com/catalyst-cooperative/pudl-usage-metrics/actions/runs/11292667735).

What did you change in this PR?
Added a gcloud set up step mirroring the one used in save_daily_metrics.yml, and specified the shell running the gcloud command.

Testing

How did you make sure this worked? How can a reviewer verify this?
See https://github.com/catalyst-cooperative/pudl-usage-metrics/actions/runs/11292842735.

To-do list

Tasks

@e-belfer e-belfer added the bug Something isn't working label Oct 11, 2024
@e-belfer e-belfer self-assigned this Oct 11, 2024
Copy link
Member

@jdangerx jdangerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Small suggestion to add a little context around the strange bash -l {0} if possible, but totally fine to merge as is as well.

- name: Whitelist Github Action and Superset IPs
shell: bash -l {0}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was necessary for this step but not the later IP-clearing step? Weird... if you have any context on what was going on that necessitated this it might be nice to include as a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants