Skip to content

Commit

Permalink
Move dagster modules to pyproject instead of cli command (#3865)
Browse files Browse the repository at this point in the history
  • Loading branch information
bendnorman authored Sep 24, 2024
1 parent db0319c commit 12e3e67
Show file tree
Hide file tree
Showing 7 changed files with 44 additions and 47 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ VPATH = environments:${PUDL_OUTPUT}
########################################################################################
.PHONY: dagster
dagster:
dagster-webserver -m pudl.etl -m pudl.ferc_to_sqlite
dagster-webserver

.PHONY: jlab
jlab:
Expand Down
11 changes: 1 addition & 10 deletions docs/dev/run_the_etl.rst
Original file line number Diff line number Diff line change
Expand Up @@ -182,16 +182,7 @@ Once ``DAGSTER_HOME`` is set, launch the dagster UI by running:

.. code-block:: console
$ dagster-webserver -m pudl.etl -m pudl.ferc_to_sqlite
To avoid typing out the ``dagster-webserver`` command each time you want to launch
the UI, you can create an alias for the command in your shell:

.. code-block:: console
$ echo "alias launch_dagster='dagster-webserver -m pudl.etl -m pudl.ferc_to_sqlite'" >> ~/.zshrc # zsh
$ echo "alias launch_dagster='dagster-webserver -m pudl.etl -m pudl.ferc_to_sqlite'" >> ~/.bashrc # bash
$ alias launch_dagster="dagster-webserver -m pudl.etl -m pudl.ferc_to_sqlite" # fish
$ make dagster
.. note::

Expand Down
6 changes: 3 additions & 3 deletions environments/conda-linux-64.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

57 changes: 30 additions & 27 deletions environments/conda-lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions environments/conda-osx-64.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions environments/conda-osx-arm64.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -372,3 +372,6 @@ exclude_lines = [
# Stuff that's not expected to run normally...
"logger.debug",
]

[tool.dagster]
modules = [{ type = "module", name = "pudl.etl" }, { type = "module", name = "pudl.ferc_to_sqlite" }]

0 comments on commit 12e3e67

Please sign in to comment.