Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PUDL to use frictionless v5 #3569

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Update PUDL to use frictionless v5 #3569

merged 4 commits into from
Apr 15, 2024

Conversation

zaneselvans
Copy link
Member

@zaneselvans zaneselvans commented Apr 15, 2024

Overview

Testing

  • Ran make pytest-coverage locally in the new environment, using ferc-xbrl-extractor>=1.4.0 and everything seemed to work.

To-do list

Comment on lines -228 to +230
- jsonschema=4.21.1=pyhd8ed1ab_0
- jsonschema-specifications=2023.12.1=pyhd8ed1ab_0
- jsonschema-with-format-nongpl=4.21.1=pyhd8ed1ab_0
- jsonschema=4.17.3=pyhd8ed1ab_0
- jsonschema-with-format-nongpl=4.17.3=pyhd8ed1ab_0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that frictionless is currently pinning to jsonschema<4.18 and jupyter_events also depends on that package, which results in a downgrade of some jupyter packages below.

See frictionlessdata/frictionless-py#1569

@zaneselvans zaneselvans changed the title Relock conda environment to use frictionless v5 Update to use frictionless v5 Apr 15, 2024
@zaneselvans zaneselvans changed the title Update to use frictionless v5 Update PUDL to use frictionless v5 Apr 15, 2024
src/pudl/workspace/datastore.py Outdated Show resolved Hide resolved
Copy link
Member

@jdangerx jdangerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to just "commit suggestion" since there's no sense in going back-and-forth just to delete an obsolete TODO. Approved.

@zaneselvans
Copy link
Member Author

TODID TODONE

@zaneselvans
Copy link
Member Author

Silly stochastic unit test failure. Re-running.

@zaneselvans zaneselvans added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit ffda371 Apr 15, 2024
14 checks passed
@zaneselvans zaneselvans deleted the frictionless-5 branch April 15, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants