Lint GHA workflows in pre-commit. #3870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh this is a good idea. You want to add it to our other repos as well? The archiver, cheshire, user metrics, and ferc xbrl extractor? |
zaneselvans
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This takes basically no additional time in pre-commit and will stop you from accidentally committing a bad GHA workflow & tearing your hair out over it.
What did you change?
Add
actionlint, which appears to be the community standard GHA linter.Testing
How did you make sure this worked? How can a reviewer verify this?
I added a typo and it yelled at me.