Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an asset factory for FERC 1 output tables #3883

Merged
merged 16 commits into from
Oct 1, 2024
Merged

Conversation

e-belfer
Copy link
Member

@e-belfer e-belfer commented Sep 30, 2024

Overview

Closes #3147 and supercedes #3557.

What problem does this address?

Taking over the draft PR in #3557 started by @hfireborn and finishing it. Creates an asset factory for all identical out_ferc1__ tables which just join in the utility IDs. Adding more complex FERC1 output tables into this pattern is out of scope for now.

What did you change?

Adds ferc1_output_asset_factory to pudl.output.ferc1.py and removes the corresponding table asset definitions.

Documentation

Make sure to update relevant aspects of the documentation.

Tasks

Preview Give feedback

Testing

How did you make sure this worked? How can a reviewer verify this?

Regenerated out_ferc1 asset group and ran pytest ${pytest_args} -n 4 --no-cov --live-dbs test/validate/ferc1_test.py.

To-do list

Preview Give feedback

@e-belfer e-belfer added ferc1 Anything having to do with FERC Form 1 dagster Issues related to our use of the Dagster orchestrator labels Sep 30, 2024
@e-belfer e-belfer self-assigned this Sep 30, 2024
@e-belfer e-belfer changed the title Ferc1 asset factory Create an asset factory for FERC 1 output tables Sep 30, 2024
Copy link
Member

@zaneselvans zaneselvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finishing this off and pulling it in.

@e-belfer e-belfer added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit cb4a739 Oct 1, 2024
17 checks passed
@e-belfer e-belfer deleted the ferc1-asset-factory branch October 1, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dagster Issues related to our use of the Dagster orchestrator ferc1 Anything having to do with FERC Form 1
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Consolidate ferc1 outputs using Dagster asset factories
3 participants