Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourceasset to assetspec #3983

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ggurjar333
Copy link
Contributor

@ggurjar333 ggurjar333 commented Dec 3, 2024

Overview

Closes #3977.

What problem does this address?

What did you change?

Documentation

Make sure to update relevant aspects of the documentation.

Tasks

Preview Give feedback

Testing

How did you make sure this worked? How can a reviewer verify this?

To-do list

Preview Give feedback

@@ -358,9 +358,9 @@ def create_raw_ferc1_assets() -> list[SourceAsset]:
)
dbf_table_names = tuple(set(flattened_dbfs))
raw_ferc1_dbf_assets = [
SourceAsset(
AssetSpec(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to @bendnorman's investigation in #3977 it looks like you need to do something like

AssetSpec(key=AssetKey("...")).with_io_manager_key("...")

Instead of adding the io_manager_key to the metadata dictionary.

Does that address the issues you are having with AssetSpec configuration you were mentioning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Switch from using the deprecated SourceAsset to AssetSpec
2 participants