Pass sources
to DataSource.from_id()
#4013
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Relevant to catalyst-cooperative/pudl-archiver#506.
What problem does this address?
In #4003 I updated
DataSource.dict_from_id()
to takesources
. However,from_id()
is an upstream method called in thepudl-archiver
repository, and I neglected to addsources
as a parameter here. This PR fixes this problem.What did you change?
sources
as a parameter toDataSource.from_id()
SOURCES
the default infrom_id()
and notdict_from_id()
.from_id()
is more widely called both in PUDL and thepudl-archiver
repo, and this removes duplicate defaults in the class.Documentation
Make sure to update relevant aspects of the documentation.
Tasks
Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list