Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update simplesamlphp to 2.3.5 #853

Merged
merged 9 commits into from
Dec 16, 2024
Merged

Update simplesamlphp to 2.3.5 #853

merged 9 commits into from
Dec 16, 2024

Conversation

gbarat87
Copy link
Contributor

No description provided.

@jay-oswald
Copy link
Contributor

jay-oswald commented Dec 12, 2024 •
edited
Loading

Looks good, same commits cherry-picked from my previous bump, just the 405 tests are now failing, they were passing

gbarat87 and others added 8 commits December 13, 2024 15:46
@gbarat87
bump simplesamlphp to 2.3.5
5c5ae7e
@hdagheda @gbarat87
WR #333356: Manually apply below patch due to dir change:
8d31014 
extlib-simplesaml: backport mods to extlib. 3063297
Added support for IdP initiation flow #105 6ebf501
Fixed bug with Idp initiatied entityid ca34393

Edited 04/10/23 for peer review of pull #774
@sarahjcotton @gbarat87
Issue #768: Remove unnecessary param being sent to sendSAML2AuthnRequ…
9c0953d 
…est()
@sarahjcotton @gbarat87
Issue #768: Force de-prioritisation of BINDING_HTTP_ARTIFACT
365ed7f
@aneno-m-e @gbarat87
Update post.twig to point to publicly available post files (#793)
3df562c 
And remove deprecated post.php

Co-authored-by: Noemie Ariste <[email protected]>
@jwalits @gbarat87
[#801] fix issue with IdP initiated login after upgrade to v2.0.5 (#802)
521f23d 
* [#801] fix issue with IdP initiated login after upgrade to v2.0.5

* [#801] restore comment for searching purposes
@skodak @gbarat87
set SESSION->saml2idp during unsolicited logins
4b5700e 
This makes the IdP known in saml_login_complete()
and tenant callback.
@gbarat87
Update readme with new simplesamlphp version
287d8aa
@gbarat87 gbarat87 force-pushed the MOODLE_404_STABLE-simplesamlphp-update branch from af159ce to 287d8aa Compare December 13, 2024 05:48
@gbarat87
Copy link
Contributor Author

I have made a mistake, the upgrade step composer remove phpmailer/phpmailer actually include all other library.
And so an update of the phpunit one.
So I have run again composer install --no-dev to remove all the unwanted library

@jay-oswald jay-oswald mentioned this pull request Dec 16, 2024
Open
@jay-oswald
Copy link
Contributor

@gbarat87 Looks good, can you just add a version bump so it will release it with the bump

jay-oswald
jay-oswald approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@jay-oswald jay-oswald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now with the bump

@jay-oswald jay-oswald merged commit 54928e5 into MOODLE_404_STABLE Dec 16, 2024
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jay-oswald jay-oswald jay-oswald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gbarat87 @jay-oswald @hdagheda @sarahjcotton @aneno-m-e @jwalits @skodak