Fix unit tests in auth_plugin_test.php #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmitriim - looks like github actions caught this but the actions config "skipped" a subsequent run and so reported a succesful "skip" rather than a succesful run? |
|
yeah. Looks like I missed that. Thanks @wo14580 for providing a fix. |
dmitriim
reviewed
Dec 5, 2023
tests/auth_plugin_test.php
Outdated
|
|
||
| $this->expectException(moodle_exception::class); | ||
| $this->expectExceptionMessage('Unsupported redirect to http://google.com detected, execution terminated.'); | ||
| $this->expectExceptionMessage( | ||
| sprintf("Unsupported redirect to %s detected, execution terminated.", SELF::REDIRECTION_PATH) |
There was a problem hiding this comment.
CI doesn't like this line:
1052 | ERROR | [x] Must use "self::" for local static member reference; found "SELF::"
| | (Squiz.Classes.SelfMemberReference.IncorrectCase
There was a problem hiding this comment.
My bad, it seems normal that it doesn't like it ;-)
I changed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue issue 97, a first fix was done by replacing PARAM_URL by PARAM_LOCALURL (commit)
Some of the unit tests were broken because of the entire url redirection.
In this PR I replaced the redirection to google by a local redirection.
To test it:
vendor/bin/phpunit auth/userkey/tests/auth_plugin_test.php