Fix issue with type extension

catalyst · Jan 19, 2024 · 0fd2fb2 · 0fd2fb2
1 parent 4bff5f9
commit 0fd2fb2
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 0 deletions.
diff --git a/classes/converter.php b/classes/converter.php
@@ -418,6 +418,10 @@ public function poll_conversion_status(conversion $conversion) {
      * @return  bool
      */
     public static function supports($from, $to) {
+        // Make sure we receive the extensions in lowercase.
+        $from = strtolower($from);
+        $to = strtolower($to);
+
         // This is not a one-liner because of php 5.6.
         $imports = self::$imports;
         $exports = self::$exports;

diff --git a/tests/converter_test.php b/tests/converter_test.php
@@ -546,4 +546,49 @@ public function test_conversion_record_deduplication() {
         $task->execute();
         $this->assertEquals(2, $DB->count_records('file_conversion'));
     }
+
+    /**
+     * Data provider for test_supports
+     * Supported formats: 'doc', 'docx', 'rtf', 'xls', 'xlsx', 'ppt', 'pptx', 'html', 'odt',
+     * 'ods', 'txt', 'png', 'jpg', 'gif', 'pdf'
+     *
+     * @return array
+     */
+    public function supports_provider() {
+        return [
+            ['doc', true], ['DOC', true],
+            ['docx', true], ['DOCX', true],
+            ['rtf', true], ['RTF', true],
+            ['xls', true], ['XLS', true],
+            ['xlsx', true], ['XLSX', true],
+            ['ppt', true], ['PPT', true],
+            ['pptx', true], ['PPTX', true],
+            ['html', true], ['HTML', true],
+            ['odt', true], ['ODT', true],
+            ['ods', true], ['ODS', true],
+            ['txt', true], ['TXT', true],
+            ['png', true], ['PNG', true],
+            ['jpg', true], ['JPG', true],
+            ['gif', true], ['GIF', true],
+            ['pdf', false], ['PDF', false],
+            ['mp3', false], ['MP3', false],
+            ['mp4', false], ['mp4', false],
+        ];
+    }
+
+    /**
+     * Test supports method of converter class.
+     *
+     * @covers       converter::supports
+     * @dataProvider supports_provider
+     *
+     * @param string $format The format to test.
+     * @param bool $expected The expected result.
+     *
+     */
+    public function test_supports($format, $expected) {
+        // Check supported format.
+        $this->assertEquals($expected, \fileconverter_librelambda\converter::supports($format, 'pdf'));
+        $this->assertEquals($expected, \fileconverter_librelambda\converter::supports($format, 'PDF'));
+    }
 }