WR421526:Removed MOODLE_INTERNAL_CHECKS for standards compliance

Coding standards changed and these checks were cluttering the ci linting, making it hard to see "real" issues.
catalyst · Dec 18, 2023 · a6ac198 · a6ac198
1 parent 3ba6987
commit a6ac198
Show file tree

Hide file tree

Showing 20 changed files with 1 addition and 39 deletions.
diff --git a/classes/event/event_processed.php b/classes/event/event_processed.php
@@ -24,8 +24,6 @@
 
 namespace local_assessfreq\event;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Event class.
  *

diff --git a/classes/output/all_participants_inprogress.php b/classes/output/all_participants_inprogress.php
@@ -26,8 +26,6 @@
 
 use local_assessfreq\quiz;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Renderable for all participant summary card.
  *

diff --git a/classes/output/assess_by_activity.php b/classes/output/assess_by_activity.php
@@ -26,8 +26,6 @@
 
 use local_assessfreq\frequency;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Renderable for assessments by activity card.
  *

diff --git a/classes/output/assess_by_month.php b/classes/output/assess_by_month.php
@@ -26,8 +26,6 @@
 
 use local_assessfreq\frequency;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Renderable for assessments due by month card.
  *

diff --git a/classes/output/assess_by_month_student.php b/classes/output/assess_by_month_student.php
@@ -26,8 +26,6 @@
 
 use local_assessfreq\frequency;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Renderable for assessments due by month student card.
  *

diff --git a/classes/output/inprogress_participant_summary.php b/classes/output/inprogress_participant_summary.php
@@ -24,8 +24,6 @@
 
 namespace local_assessfreq\output;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Renderable for participant summary card.
  *

diff --git a/classes/output/participant_summary.php b/classes/output/participant_summary.php
@@ -26,8 +26,6 @@
 
 use local_assessfreq\quiz;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Renderable for participant summary card.
  *

diff --git a/classes/output/participant_trend.php b/classes/output/participant_trend.php
@@ -26,8 +26,6 @@
 
 use local_assessfreq\quiz;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Renderable for participant trend card.
  *

diff --git a/classes/output/renderer.php b/classes/output/renderer.php
@@ -25,8 +25,6 @@
 
 use local_assessfreq\quiz;
 
-defined('MOODLE_INTERNAL') || die;
-
 use plugin_renderer_base;
 use local_assessfreq\frequency;
 

diff --git a/classes/output/upcomming_quizzes.php b/classes/output/upcomming_quizzes.php
@@ -26,8 +26,6 @@
 
 use local_assessfreq\quiz;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Renderable for upcomming quizzes card.
  *

diff --git a/classes/privacy/provider.php b/classes/privacy/provider.php
@@ -24,8 +24,6 @@
 
 namespace local_assessfreq\privacy;
 
-defined('MOODLE_INTERNAL') || die();
-
 use core_privacy\local\metadata\collection;
 use core_privacy\local\request\contextlist;
 use core_privacy\local\request\approved_contextlist;

diff --git a/classes/quiz.php b/classes/quiz.php
@@ -26,8 +26,6 @@
 
 use mod_quiz\question\bank\qbank_helper;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Quiz data class.
  *

diff --git a/classes/task/data_process.php b/classes/task/data_process.php
@@ -25,8 +25,6 @@
 
 use core\task\scheduled_task;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * A scheduled task to generate data used in plugin reports.
  *

diff --git a/classes/task/history_process.php b/classes/task/history_process.php
@@ -25,8 +25,6 @@
 
 use core\task\adhoc_task;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Adhoc task to process historical data used in plugin.
  *

diff --git a/classes/task/quiz_tracking.php b/classes/task/quiz_tracking.php
@@ -25,8 +25,6 @@
 
 use core\task\scheduled_task;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * A scheduled task to track the process of quizzes in the system.
  *

diff --git a/classes/utils.php b/classes/utils.php
@@ -24,8 +24,6 @@
 
 namespace local_assessfreq;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Utils class.
  *

diff --git a/db/install.php b/db/install.php
@@ -22,8 +22,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Generate ad-hoc task on install.
  */

diff --git a/lib.php b/lib.php
@@ -22,8 +22,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die();
-
 
 /**
  * Returns the name of the user preferences as well as the details this plugin uses.

diff --git a/tests/external_test.php b/tests/external_test.php
@@ -24,8 +24,6 @@
 
 namespace local_assessfreq;
 
-defined('MOODLE_INTERNAL') || die();
-
 use assign;
 use context_module;
 use external_api;

diff --git a/version.php b/version.php
@@ -27,7 +27,7 @@
 $plugin->component = 'local_assessfreq';
 $plugin->release = '2023102700';
 $plugin->version = 2023102700;
-$plugin->requires = 2023042400; // Requires 4.2
+$plugin->requires = 2023042400; // Requires 4.2.
 $plugin->supports = [402, 402];
 $plugin->maturity = MATURITY_STABLE;