Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export #88

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Add export #88

merged 1 commit into from
Jul 8, 2024

Conversation

matthewhilton
Copy link
Contributor

Changes

  • Adds table_sql's built in downloading function, allowing users to download the report:

image

As part of this:

  • The URIs are fully expanded in download mode (truncated normally)
  • The action column is empty when exporting (to avoid accidental clicking to delete result in HTML export). While it would be ideal to remove the column altogether, it is far simpler code-wise with the current layout of the page to just simply make it empty.

Testing

Manual testing:

  1. Enabled CSP headers in plugin settings
  2. Went to CSP test page, this generates csp reports
  3. Went to CSP report page, downloaded main report, works as expected
  4. Drilled down into CSP reports by clicking on number at start of one of the rows
  5. Downloaded drill-down report, works as expected
Main export Drill down export
image image

@matthewhilton matthewhilton force-pushed the add-export branch 2 times, most recently from 8f683f0 to 0ecdb61 Compare July 5, 2024 04:39
csp_report.php Outdated Show resolved Hide resolved
@brendanheywood brendanheywood merged commit 62121a6 into MOODLE_401_STABLE Jul 8, 2024
19 checks passed
@brendanheywood brendanheywood deleted the add-export branch July 8, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants