Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
2 issues:
library
submodule changes it font files, it would previously completely error outChanges
library
submodule versions. (did not update the library submodule, as that is another can of worms)hvp_is_branded() -> true
which tells moodle not to apply the filter to the image (this is the same thing that mod_h5p does)Testing
CI Note
Additionally, I updated the CI to only run unit tests - we are not going to fix the pre-existing style issues inherited from the upstream.