Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

45 bug fixes #68

Open
wants to merge 3 commits into
base: stable-catalyst-400
Choose a base branch
from
Open

45 bug fixes #68

wants to merge 3 commits into from

Conversation

matthewhilton
Copy link

@matthewhilton matthewhilton commented Jan 21, 2025

Issues
2 issues:

  1. For mobile offline, When the library submodule changes it font files, it would previously completely error out
  2. The icon had some filter being applied to it making it unreadable

hvp icon

Changes

  1. If a font file is missing we just skip it. There isn't a nice way to tell exactly what files are where, so for now I think just manually updating this list when needed is ok. Also added the newer font files that are in the newer library submodule versions. (did not update the library submodule, as that is another can of worms)
  2. Icon fixed by defining hvp_is_branded() -> true which tells moodle not to apply the filter to the image (this is the same thing that mod_h5p does)

Testing

  1. Font file - correctly skips font files
  2. Icon - correctly shows the icon without filtering

CI Note
Additionally, I updated the CI to only run unit tests - we are not going to fix the pre-existing style issues inherited from the upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant