Skip to content

Commit

Permalink
Merge pull request #66 from catalyst/issue63
Browse files Browse the repository at this point in the history
issue #63: fix deprecated call when rendering a button
  • Loading branch information
dmitriim authored Mar 26, 2024
2 parents 9f3f735 + b222bf0 commit 227ffa3
Show file tree
Hide file tree
Showing 4 changed files with 51 additions and 4 deletions.
5 changes: 4 additions & 1 deletion index.php
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@

echo $OUTPUT->header();
echo $OUTPUT->heading(get_string('managerules', 'tool_dynamic_cohorts'));
echo $OUTPUT->single_button($editurl, get_string('addrule', 'tool_dynamic_cohorts'), 'post', ['primary' => true]);
echo $OUTPUT->render_from_template('tool_dynamic_cohorts/button', [
'url' => $editurl->out(),
'text' => get_string('addrule', 'tool_dynamic_cohorts'),
]);
echo $report->output();
echo $OUTPUT->footer();
41 changes: 41 additions & 0 deletions templates/button.mustache
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
{{!
This file is part of Moodle - https://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template tool_dynamic_cohorts/button
Button.
Classes required for JS:
* none
Data attributes required for JS:
* none
Context variables required for this template:
* url - URL of the button.
* text - Text of the button.
Example context (json):
{
"url" : "https://example.com/admin/tool/dynamic_cohorts/edit.php",
"text" : "Add new rule"
}
}}

<a href="{{url}}" class="btn btn-primary">
{{text}}
</a>
5 changes: 4 additions & 1 deletion users.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@

echo $OUTPUT->header();
echo $OUTPUT->heading($heading);
echo $OUTPUT->single_button($indexurl, get_string('backtolistofrules', 'tool_dynamic_cohorts'), 'post', ['primary' => true]);
echo $OUTPUT->render_from_template('tool_dynamic_cohorts/button', [
'url' => $indexurl->out(),
'text' => get_string('backtolistofrules', 'tool_dynamic_cohorts'),
]);
echo $report->output();
echo $OUTPUT->footer();
4 changes: 2 additions & 2 deletions version.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
defined('MOODLE_INTERNAL') || die();

$plugin->component = 'tool_dynamic_cohorts';
$plugin->release = 2024032501;
$plugin->version = 2024032501;
$plugin->release = 2024032600;
$plugin->version = 2024032600;
$plugin->requires = 2022112800;
$plugin->supported = [401, 403];
$plugin->maturity = MATURITY_STABLE;

0 comments on commit 227ffa3

Please sign in to comment.