S3 pre-signed URL: error with unicode filename #455 #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhucNguyen0311
force-pushed
the
s3-pre-signed-url
branch
from
755396d
to
4102568
Compare
|
@PhucNguyen0311 can you please rebase this? |
|
I am closing this as this seem to be integrated via https://github.com/catalyst/moodle-tool_objectfs/pull/493/commits If it is not the case, please feel free to create new PR against our STABLE Branches MOODLE_33_STABLE/MOODLE_310_STABLE Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have submitted a fix for issue "S3 pre-signed URL: error with unicode filename" #455. Please help me to review this.