Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mworks parsing that includes filename for non-normalizers #48

Closed
wants to merge 2 commits into from

Conversation

h-mayorquin
Copy link
Collaborator

This PR changes the mworks parsing so the filename is available for normal (non-normalizer) sessions.

Hey @yoonbai I noticed that the parsing of mworks that adds the filename is missing from non-normalizer stimulus (which is using mwk_rsvp_new) for some reason.

Was this intentional?

@yoonbai
Copy link
Collaborator

yoonbai commented Jan 22, 2025

Previously, there were two files, mwk_rsvp and mwk_rsvp_new, that were essentially the same expect for dealing with additional fields such as the stimulus hash. I aggregated them into one file, mwk_rsvp, to prevent confusion. When comparing the two files, I didn't see differences in the resulting filename (or maybe you were referring to the filename as something else?). In summary, moving forward, we should only have one file, mwk_rsvp (not mwk_rsvp_new), for parsing RSVP tasks

@h-mayorquin
Copy link
Collaborator Author

Closing this in favor of #50

@h-mayorquin h-mayorquin deleted the missing_new_works_parsing branch January 27, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants