Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tutorial notebook #30

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Add tutorial notebook #30

merged 3 commits into from
Jun 4, 2024

Conversation

weiglszonja
Copy link
Collaborator

Add demo notebook for the Azcorra 2023 converted dataset

@weiglszonja weiglszonja self-assigned this May 27, 2024
alessandratrapani
alessandratrapani approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@alessandratrapani alessandratrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tutorial looks amazing! The only small comment on my side: I think the FiberPhotometryResponseSeries are missing from the png uml.

@weiglszonja
Copy link
Collaborator Author

This tutorial looks amazing! The only small comment on my side: I think the FiberPhotometryResponseSeries are missing from the png uml.

Ah thanks, that was actually intentional because I thought it's too complex already, but might be misleading to leave it out on the other hand?

@alessandratrapani
Copy link
Contributor

This tutorial looks amazing! The only small comment on my side: I think the FiberPhotometryResponseSeries are missing from the png uml.

Ah thanks, that was actually intentional because I thought it's too complex already, but might be misleading to leave it out on the other hand?

Yeah, maybe add just one of the FiberPhotometryResponseSeries, since it is one of the most important data here.

@weiglszonja weiglszonja mentioned this pull request May 30, 2024
Open
21 tasks
@weiglszonja weiglszonja merged commit 5648677 into main Jun 4, 2024
@weiglszonja weiglszonja deleted the add_tutorial branch June 4, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandratrapani alessandratrapani alessandratrapani approved these changes

Assignees

@weiglszonja weiglszonja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiglszonja @alessandratrapani