Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repack Nwb Files #1003
base: main
Are you sure you want to change the base?
Repack Nwb Files #1003
Changes from 16 commits
7304229
4cc2a06
c33dfbf
80c1fba
7ee6fc6
dacdeea
dae04bf
4ac6e33
ce267fb
49f4262
d93a5c5
ab8b22f
934bb3a
1ad69ca
04fb89c
6dab477
e6d31a6
7252449
2ef5c44
80eb598
433f8c9
dd906ac
668cacc
7796197
b8a788c
f631fb4
b089eb3
c464764
1cf3629
481529f
1e6b119
9f02b61
9ee146f
ee7ec52
a2145a1
5785af0
b07c002
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see many more tests here; starting with more basic types like
TimeSeries
,DynamicTable
, etc. before working our way up to the edge case that is an ImageSeries (external vs. internal mode too on that)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep in mind the intended point of this function; to start with objects that are either uncompressed, unchuncked, or badly chunked; and then we create a new copy of the file that has better compression and chunking on all applicable datasets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add an integration test where we write a new NWB file with a different backend configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... You mean something like 'make a Zarr-backend copy of this existing HDF5-backend NWB file'? Or same type of backend (such as both HDF5) but different configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question. Both, I guess. I just want to make sure this works end-to-end and does not require us to do anything funky in practice