Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore public status of NWBMetaDataEncoder encoder #1142

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

h-mayorquin
Copy link
Collaborator

This should fix #1141.

I want to do this after #1139 to minimize conflict errors. This PR has #1139 as base.

@h-mayorquin h-mayorquin self-assigned this Nov 14, 2024
Base automatically changed from support_datetime_on_conversion_options to main November 14, 2024 13:47
@h-mayorquin h-mayorquin marked this pull request as ready for review November 15, 2024 23:34
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.68%. Comparing base (64fb9e0) to head (f56bb7d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
+ Coverage   90.58%   90.68%   +0.09%     
==========================================
  Files         128      129       +1     
  Lines        8011     8178     +167     
==========================================
+ Hits         7257     7416     +159     
- Misses        754      762       +8     
Flag Coverage Δ
unittests 90.68% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/neuroconv/basedatainterface.py 95.34% <100.00%> (ø)
...aces/behavior/neuralynx/neuralynx_nvt_interface.py 98.38% <100.00%> (+0.02%) ⬆️
...nv/tools/nwb_helpers/_metadata_and_file_helpers.py 86.57% <100.00%> (-0.09%) ⬇️
...c/neuroconv/tools/testing/data_interface_mixins.py 95.55% <100.00%> (ø)
src/neuroconv/utils/__init__.py 50.00% <ø> (ø)
src/neuroconv/utils/json_schema.py 95.03% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: No ImportError when calling from neuroconv.utils import NWBMetaDataEncoder
1 participant