Change identifier of plane to plane_segmentation_name
#623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Closed
2 tasks
…ntation_name' into change_identifier_to_plane_segmentation_name # Conflicts: # tests/test_ophys/test_tools_roiextractors.py
weiglszonja
commented
Oct 31, 2023
weiglszonja
commented
Nov 3, 2023
Co-authored-by: Szonja Weigl <[email protected]>
CodyCBakerPhD
approved these changes
Nov 3, 2023
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #623 +/- ##
==========================================
- Coverage 91.73% 91.62% -0.12%
==========================================
Files 106 106
Lines 5434 5444 +10
==========================================
+ Hits 4985 4988 +3
- Misses 449 456 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
CodyCBakerPhD
deleted the
change_identifier_to_plane_segmentation_name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #603
plane_segmentation_nameto identify whichPlaneSegmentationto add from ophys metadataplane_segmentation_nameatBaseSegmentationExtractorInterface.add_to_nwbfile()to support adding segmentation output from multiple planesRelated to Update
Suite2pSegmentationInterfaceto support multiple channels and planes #601